lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Oct 2022 16:47:44 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Shai Malin <smalin@...dia.com> Cc: Aurelien Aptel <aaptel@...dia.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>, Saeed Mahameed <saeedm@...dia.com>, Tariq Toukan <tariqt@...dia.com>, "leon@...nel.org" <leon@...nel.org>, "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>, "sagi@...mberg.me" <sagi@...mberg.me>, "hch@....de" <hch@....de>, "kbusch@...nel.org" <kbusch@...nel.org>, "axboe@...com" <axboe@...com>, Chaitanya Kulkarni <chaitanyak@...dia.com>, Or Gerlitz <ogerlitz@...dia.com>, Yoray Zack <yorayz@...dia.com>, Boris Pismenny <borisp@...dia.com>, "aurelien.aptel@...il.com" <aurelien.aptel@...il.com>, "malin1024@...il.com" <malin1024@...il.com> Subject: Re: [PATCH v7 01/23] net: Introduce direct data placement tcp offload On Mon, 31 Oct 2022 18:13:19 +0000 Shai Malin wrote: > > Then there are stats. > > In the patch "net/mlx5e: NVMEoTCP, statistics" we introduced > rx_nvmeotcp_* stats. > We believe it should be collected by the device driver and not > by the ULP layer. I'm not sure I agree, but that's not the key point. The key point is that we want the stats to come via a protocol specific interface, and not have to be fished out of the ethtool -S goop. You can still collect them in the driver, if we have any ULP-level stats at any point we can add them to the same interface.
Powered by blists - more mailing lists