lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Oct 2022 10:35:48 +0800 From: Menglong Dong <menglong8.dong@...il.com> To: Eric Dumazet <edumazet@...gle.com> Cc: kuba@...nel.org, davem@...emloft.net, pabeni@...hat.com, yoshfuji@...ux-ipv6.org, dsahern@...nel.org, imagedong@...cent.com, kafai@...com, asml.silence@...il.com, keescook@...omium.org, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH net-next 1/9] net: skb: introduce try_kfree_skb() On Sat, Oct 29, 2022 at 11:30 PM Eric Dumazet <edumazet@...gle.com> wrote: > > On Sat, Oct 29, 2022 at 6:11 AM <menglong8.dong@...il.com> wrote: > > > > From: Menglong Dong <imagedong@...cent.com> > > > > In order to simply the code, introduce try_kfree_skb(), which allow > > SKB_NOT_DROPPED_YET to be passed. When the reason is SKB_NOT_DROPPED_YET, > > consume_skb() will be called to free the skb normally. Otherwise, > > kfree_skb_reason() will be called. > > > > Signed-off-by: Menglong Dong <imagedong@...cent.com> > > --- > > include/linux/skbuff.h | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > > index 59c9fd55699d..f722accc054e 100644 > > --- a/include/linux/skbuff.h > > +++ b/include/linux/skbuff.h > > @@ -1236,6 +1236,15 @@ static inline void consume_skb(struct sk_buff *skb) > > } > > #endif > > > > +static inline void try_kfree_skb(struct sk_buff *skb, > > + enum skb_drop_reason reason) > > +{ > > + if (reason != SKB_NOT_DROPPED_YET) > > + kfree_skb_reason(skb, reason); > > + else > > + consume_skb(skb); > > +} > > + > > My proposal looks better IMO > > https://patchwork.kernel.org/project/netdevbpf/patch/20221028133043.2312984-2-edumazet@google.com/ Hnn...yeah, your idea seems fine, which wont affect the existing code.
Powered by blists - more mailing lists