netdev - RE: Linux 6.1-rc3 build fail in include/linux/bpf.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <439af02a169149f28ba0a4e3bbc729ee@AcuMS.aculab.com>
Date:   Mon, 31 Oct 2022 12:03:15 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     David Laight <David.Laight@...LAB.COM>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Jiri Olsa <jolsa@...nel.org>
Subject: RE: Linux 6.1-rc3 build fail in include/linux/bpf.h

From: David Laight
> Sent: 31 October 2022 11:15
> 
> The 6.1-rc3 sources fail to build because bpf.h unconditionally
> #define BPF_DISPATCHER_ATTRIBUTES __attribute__((patchable_function_entry(5)))
> for X86_64 builds.
> 
> I'm pretty sure that should depend on some other options
> since the compiler isn't required to support it.
> (The gcc 7.5.0 on my Ubunti 18.04 system certainly doesn't)
> 
> The only other reference to that attribute is in the definition
> of 'notrace' in compiler.h.

I think patchable_function_entry was added in gcc 8.
Documentation/process/changes.rst gives the minimal gcc version for
building the kernel as 5.1.

I doubt a increasing it to 8 is acceptable.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)