netdev - Re: [PATCH net-next v8 6/9] devlink: Allow to change priv in devlink-rate from parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Oct 2022 13:22:53 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Michal Wilczynski <michal.wilczynski@...el.com>
Cc:     netdev@...r.kernel.org, alexandr.lobakin@...el.com,
        jacob.e.keller@...el.com, jesse.brandeburg@...el.com,
        przemyslaw.kitszel@...el.com, anthony.l.nguyen@...el.com,
        kuba@...nel.org, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next v8 6/9] devlink: Allow to change priv in
 devlink-rate from parent_set callbacks

Fri, Oct 28, 2022 at 12:51:40PM CEST, michal.wilczynski@...el.com wrote:
>>From driver perspective it doesn't make any sense to make any changes to
>the internal HQoS tree if the created node doesn't have a parent. So a
>node created without any parent doesn't have to be initialized in the
>driver. Allow for such scenario by allowing to modify priv in parent_set
>callbacks.
>
>Change priv parameter to double pointer, to allow for setting priv during
>the parent set phase.

I fail to understand the reason for this patch, but anyway, it looks
very hacky. The priv is something the leaf/node is created with.
Changing it from the callback awfully smells like wrong design. Please
don't do that.