netdev - Re: [PATCH net-next 1/5] sfc: check recirc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <958764a5-8b2d-fe99-c59d-fbdddd53e0bc@gmail.com>
Date:   Tue, 1 Nov 2022 13:30:10 +0000
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, edward.cree@....com
Cc:     netdev@...r.kernel.org, linux-net-drivers@....com,
        davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com,
        habetsm.xilinx@...il.com
Subject: Re: [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE
 offload

On 26/10/2022 03:40, Jakub Kicinski wrote:
> On Mon, 24 Oct 2022 10:29:21 +0100 edward.cree@....com wrote:
>> From: Edward Cree <ecree.xilinx@...il.com>
>>
>> Offloaded TC rules always match on recirc_id in the MAE, so we should
>>  check that the MAE reported support for this match before attempting
>>  to insert the rule.
>>
>> Fixes: d902e1a737d4 ("sfc: bare bones TC offload on EF100")
> 
> This commit made it to net, needs to go separately there.

Hmm I might just drop the fixes tag; the cited commit isn't really
 broken, just suboptimal.

> We still don't allow flow control to hide inside macros.
> 
> You add the checks next to each other (looking at the next patch) 
> so you can return rc from the macro and easily combine the checks
> into one large if statement. Result - close to ~1 line per check.

Ah yeah, I forgot statement-like macros can still return values.
Will fix, thanks.

-ed