lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Nov 2022 21:39:15 +0800 From: Hangbin Liu <liuhangbin@...il.com> To: Jay Vosburgh <jay.vosburgh@...onical.com> Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Jonathan Toppins <jtoppins@...hat.com>, Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...il.com>, Liang Li <liali@...hat.com> Subject: Re: [PATCH net] bonding: fix ICMPv6 header handling when receiving IPv6 messages On Tue, Nov 01, 2022 at 11:12:43AM +0100, Jay Vosburgh wrote: > Hangbin Liu <liuhangbin@...il.com> wrote: > > >Some drivers, like bnx2x, will call ipv6_gro_receive() and set skb > >IPv6 transport header before bond_handle_frame(). But some other drivers, > >like be2net, will not call ipv6_gro_receive() and skb transport header > >is not set properly. Thus we can't use icmp6_hdr(skb) to get the icmp6 > >header directly when dealing with IPv6 messages. > > I don't understand this explanation, as ipv6_gro_receive() isn't > called directly by the device drivers, but from within the GRO > processing, e.g., by dev_gro_receive(). > > Could you explain how the call paths actually differ? Er..Yes, it's a little weird. I checked if the transport header is set before __netif_receive_skb_core(). The bnx2x driver set it while be2net does not. So the transport header is reset in __netif_receive_skb_core() with be2net. I also found ipv6_gro_receive() is called before bond_handle_frame() when receive NA message. Not sure which path it go through. I'm not very familiar with driver part. But I can do more investigating. Thanks Hangbin
Powered by blists - more mailing lists