netdev - Re: [PATCH net-next 1/5] sfc: check recirc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Nov 2022 15:41:13 +0000
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     edward.cree@....com, netdev@...r.kernel.org,
        linux-net-drivers@....com, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com, habetsm.xilinx@...il.com
Subject: Re: [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE
 offload

On 01/11/2022 15:21, Jakub Kicinski wrote:
> On Tue, 1 Nov 2022 13:30:10 +0000 Edward Cree wrote:
>>> This commit made it to net, needs to go separately there.  
>>
>> Hmm I might just drop the fixes tag; the cited commit isn't really
>>  broken, just suboptimal.
> 
> Can you describe the current behavior is? Isn't the driver accepting
> rules it can't correctly offload?

The rule will pass the checks here, but then when we make the MCDI call
 to install it in hardware, MC_CMD_MAE_ACTION_RULE_INSERT will evoke an
 error response from the firmware, so the TC_SETUP_CLSFLOWER callback
 will ultimately return an error to the kernel as it should.
The advantage of having these checks in the driver is that we get a
 useful error message rather than just "Failed to insert rule in hw",
 and also save the round trip across the PCIe bus to firmware.