netdev - Re: [PATCH net-next] gro: avoid checking for a failed search

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221101085153.12ccae1c@kernel.org>
Date:   Tue, 1 Nov 2022 08:51:53 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Richard Gobert <richardbgobert@...il.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        lixiaoyan@...gle.com, alexanderduyck@...com,
        steffen.klassert@...unet.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] gro: avoid checking for a failed search

On Mon, 24 Oct 2022 07:17:49 +0200 Richard Gobert wrote:
> After searching for a protocol handler in dev_gro_receive, checking for
> failure is redundant. Skip the failure code after finding the 
> corresponding handler.

Why does it matter? You see a measurable perf win?

Please fix the data on your system when you repost.