netdev - Re: Linux 6.1-rc3 build fail in include/linux/bpf.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 01 Nov 2022 12:00:27 +0100
From:   Björn Töpel <bjorn@...nel.org>
To:     Jiri Olsa <olsajiri@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Jiri Olsa <olsajiri@...il.com>,
        David Laight <David.Laight@...lab.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        bpf@...r.kernel.org
Subject: Re: Linux 6.1-rc3 build fail in include/linux/bpf.h

Jiri Olsa <olsajiri@...il.com> writes:

> On Mon, Oct 31, 2022 at 04:21:42PM +0100, Peter Zijlstra wrote:
>> 
>> Does something crazy like the below work? It compiles but is otherwise
>> totally untested.
>
> looks good
>
> it has now the ftrace nop and the jump to the dispatcher image
> or the bpf_dispatcher_nop_func.. great :)
>
> 	bpf_dispatcher_xdp_func:
>
> 	ffffffff81cc87b0 <load1+0xcc87b0>:
> 	ffffffff81cc87b0:       0f 1f 44 00 00          nopl   0x0(%rax,%rax,1)
> 	ffffffff81cc87b5:       e9 a6 fe 65 ff          jmp    0xffffffff81328660
>
> tests work for me..  Toke, Björn, could you please check?

Awesome! Much nicer! 

For Peter's patch, feel free to add:
Acked-by: Björn Töpel <bjorn@...nel.org>