netdev - Re: [PATCH net] net: Fix memory leaks of napi->rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7632c326-5727-2c71-9895-08c540b2c8d5@gmail.com>
Date:   Wed, 2 Nov 2022 15:28:52 +0000
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        Wang Yufen <wangyufen@...wei.com>
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com, ecree@....com
Subject: Re: [PATCH net] net: Fix memory leaks of napi->rx_list

On 02/11/2022 04:27, Eric Dumazet wrote:
<snip>
> I do not think the bug is there.
> 
> Most likely tun driver is buggy.
<snip>
>> @@ -6471,6 +6481,7 @@ void __netif_napi_del(struct napi_struct *napi)
>>         list_del_rcu(&napi->dev_list);
>>         napi_free_frags(napi);
>>
>> +       flush_rx_list(napi);

But maybe it makes sense to put a WARN_ON_ONCE(!list_empty(&napi->rx_list))
 here, to catch such buggy drivers sooner.  WDYT?

-ed