netdev - Re: [PATCH net-next v4] ethtool: linkstate: add a statistic for PHY down events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221102093133.4000add1@kernel.org>
Date:   Wed, 2 Nov 2022 09:31:33 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
        Florian Fainelli <f.fainelli@...il.com>,
        Michael Chan <michael.chan@...adcom.com>,
        Andrew Lunn <andrew@...n.ch>, corbet@....net,
        hkallweit1@...il.com, linux@...linux.org.uk,
        huangguangbin2@...wei.com, chenhao288@...ilicon.com,
        moshet@...dia.com, linux@...pel-privat.de,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next v4] ethtool: linkstate: add a statistic for PHY
 down events

On Tue,  1 Nov 2022 20:57:04 -0700 Jakub Kicinski wrote:
> +	 * This statistic counts when PHY _actually_ went down, or lost link.
> +	 */

Please ignore, I just realized I forgot to commit the change:

diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index fa8e0d52dd30..15c0134ae938 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -132,6 +132,9 @@ struct ethtool_link_ext_stats {
         * actually take the physical link down, not to mention NC-SI which,
         * if present, keeps the link up regardless of host state.
         * This statistic counts when PHY _actually_ went down, or lost link.
+        *
+        * Note that we need u64 for ethtool_stats_init() and comparisons
+        * to ETHTOOL_STAT_NOT_SET, only u32 is exposed to the user.
         */
        u64 link_down_events;
 };