netdev - Re: [PATCH net-next 1/4] net: phy: aquantia: add AQR112 and AQR412 PHY IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221103113927.n3a5d7cll3ekazor@skbuf>
Date:   Thu, 3 Nov 2022 11:39:28 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Sean Anderson <sean.anderson@...o.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Colin Foster <colin.foster@...advantage.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 1/4] net: phy: aquantia: add AQR112 and AQR412
 PHY IDs

Hi Sean,

On Tue, Nov 01, 2022 at 11:36:23AM -0400, Sean Anderson wrote:
> On 11/1/22 07:48, Vladimir Oltean wrote:
> > These are Gen3 Aquantia N-BASET PHYs which support 5GBASE-T,
> > 2.5GBASE-T, 1000BASE-T and 100BASE-TX (not 10G); also EEE, Sync-E,
> > PTP, PoE.
> > 
> > I am a bit unsure about the naming convention in the driver. Since
> > AQR107 is a Gen2 PHY, I assume all functions prefixed with "aqr107_"
> > rather than "aqr_" mean Gen2+ features. So I've reused this naming
> > convention.
> 
> In Aquantia's BSP there are references to 6 generations of phys (where
> the "first" generation is the first 28nm phy; implicitly making the 40nm
> phys generation zero). As far as I can tell these are completely
> different from the generations of phys you refer to, which seem to me
> marketing names. Unfortunately, they don't have a mapping of phys to
> generations, so I'm not even sure which phys are which generations. The
> datasheets for all but the latest phys seem to have gone missing...
> 
> In any case, if it works, then I think it's reasonable to use these
> functions.

Sorry, I admit I don't know either the lithography process in which the
PHYs are produced, or the way in which PHYs are referenced in Aquantia
BSPs. I only have access to product datasheets confidentially licensed
to NXP (with registers, packaging and so forth), and the fact that they
are Gen2 or Gen3 is mentioned in the first statement of that document.
I also googled "aqr412" and came up with a product brief on the Marvell
website titled "Marvell® AQRATE GEN3 Ethernet PHYs" which lists the 112
and 412.