netdev - RE: [EXT] Re: [PATCH v3 1/1] net: fec: add initial XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PAXPR04MB91854F7D220BFD4F1617C54E89389@PAXPR04MB9185.eurprd04.prod.outlook.com>
Date:   Thu, 3 Nov 2022 14:53:15 +0000
From:   Shenwei Wang <shenwei.wang@....com>
To:     Paolo Abeni <pabeni@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
        kernel test robot <lkp@...el.com>
Subject: RE: [EXT] Re: [PATCH v3 1/1] net: fec: add initial XDP support



> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com>
> > +     if (unlikely(index < 0))
> > +             index = 0;
> > +
> > +     while (index >= fep->num_tx_queues)
> > +             index -= fep->num_tx_queues;
> 
> Not a big deal, but I think kind of optimizations are not worthy and potentially
> dangerous since late '90 ;)
> 
> You could consider switching to a simpler '%', but IMHO it's not blocking.

Agree. Will optimize it in next patch of adding xdp statistics.

Thanks,
Shenwei

> 
> 
> Cheers,
> 
> Paolo