netdev - Re: [PATCH 10/12] Drivers: hv: Don't remap addresses that are above shared_gpa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2022 23:25:19 +0800
From:   Tianyu Lan <ltykernel@...il.com>
To:     Michael Kelley <mikelley@...rosoft.com>, hpa@...or.com,
        kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, decui@...rosoft.com, luto@...nel.org,
        peterz@...radead.org, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, lpieralisi@...nel.org,
        robh@...nel.org, kw@...ux.com, bhelgaas@...gle.com, arnd@...db.de,
        hch@...radead.org, m.szyprowski@...sung.com, robin.murphy@....com,
        thomas.lendacky@....com, brijesh.singh@....com, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com,
        Tianyu.Lan@...rosoft.com, kirill.shutemov@...ux.intel.com,
        sathyanarayanan.kuppuswamy@...ux.intel.com, ak@...ux.intel.com,
        isaku.yamahata@...el.com, dan.j.williams@...el.com,
        jane.chu@...cle.com, seanjc@...gle.com, tony.luck@...el.com,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-arch@...r.kernel.org,
        iommu@...ts.linux.dev
Subject: Re: [PATCH 10/12] Drivers: hv: Don't remap addresses that are above
 shared_gpa_boundary

On 10/21/2022 1:57 AM, Michael Kelley wrote:
> With the vTOM bit now treated as a protection flag and not part of
> the physical address, avoid remapping physical addresses with vTOM set
> since technically such addresses aren't valid.  Use ioremap_cache()
> instead of memremap() to ensure that the mapping provides decrypted
> access, which will correctly set the vTOM bit as a protection flag.
> 
> While this change is not required for correctness with the current
> implementation of memremap(), for general code hygiene it's better to
> not depend on the mapping functions doing something reasonable with
> a physical address that is out-of-range.
> 
> While here, fix typos in two error messages.
> 
> Signed-off-by: Michael Kelley<mikelley@...rosoft.com>
> ---

Reviewed-by: Tianyu Lan <Tianyu.Lan@...rosoft.com>