netdev - Re: [PATCH net v2] uapi: Add missing linux/stddef.h header file to in.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJTZdDCEVL0ZuieGvTYEPOEqvdScnr77Nnb+tbBuFwx3g@mail.gmail.com>
Date:   Thu, 3 Nov 2022 10:02:47 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yang Jihong <yangjihong1@...wei.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Kees Cook <keescook@...omium.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH net v2] uapi: Add missing linux/stddef.h header file to in.h

On Thu, Nov 3, 2022 at 2:16 AM Yang Jihong <yangjihong1@...wei.com> wrote:
>
> commit 5854a09b4957 ("net/ipv4: Use __DECLARE_FLEX_ARRAY() helper") does
> not include "linux/stddef.h" header file, and tools headers update
> linux/in.h copy, BPF prog fails to be compiled:
>
>     CLNG-BPF [test_maps] bpf_flow.bpf.o
>     CLNG-BPF [test_maps] cgroup_skb_sk_lookup_kern.bpf.o
>   In file included from progs/cgroup_skb_sk_lookup_kern.c:9:
>   /root/linux/tools/include/uapi/linux/in.h:199:3: error: type name requires a specifier or qualifier
>                   __DECLARE_FLEX_ARRAY(__be32, imsf_slist_flex);
>                   ^
>   /root/linux/tools/include/uapi/linux/in.h:199:32: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int]
>                   __DECLARE_FLEX_ARRAY(__be32, imsf_slist_flex);
>                                                ^
>   2 errors generated.
>
> To maintain consistency, add missing header file to kernel.
>
> Fixes: 5854a09b4957 ("net/ipv4: Use __DECLARE_FLEX_ARRAY() helper")
> Signed-off-by: Yang Jihong <yangjihong1@...wei.com>
> ---
>
> Changes since v1:
>  - 'Fixes' tag separates by the commit message by a blank line
>  - Remove the empty line between 'Fixes' and SoB.
>  - Specify the target tree to "net" in title
>  - Wrap the commit message text to 75 chars per line (except build output)

Since it's bpf related please always use [PATCH bpf] in the subject.
Please monitor the tree and mailing lists as well.
In this case the proper fix is already in bpf tree.
https://lore.kernel.org/bpf/20221102182517.2675301-1-andrii@kernel.org/

Your fix alone is incomplete. See patch 2 in the fix above.