netdev - Re: [PATCH net-next v2 00/13] genetlink: support per op type policies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b07c567-1fbb-097e-a796-c9114a4ee501@intel.com>
Date:   Thu, 3 Nov 2022 10:09:11 -0700
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <edumazet@...gle.com>,
        <pabeni@...hat.com>, <jiri@...nulli.us>, <razor@...ckwall.org>,
        <nicolas.dichtel@...nd.com>, <gnault@...hat.com>, <fw@...len.de>
Subject: Re: [PATCH net-next v2 00/13] genetlink: support per op type policies



On 11/2/2022 2:33 PM, Jakub Kicinski wrote:
> While writing new genetlink families I was increasingly annoyed by the fact
> that we don't support different policies for do and dump callbacks.
> This makes it hard to do proper input validation for dumps which usually
> have a lot more narrow range of accepted attributes.
> 
> There is also a minor inconvenience of not supporting different per_doit
> and post_doit callbacks per op.
> 
> This series addresses those problems by introducing another op format.
> 
> v2:
>   - wait for net changes to propagate
>   - restore the missing comment in patch 1
>   - drop extra space in patch 3
>   - improve commit message in patch 4


The whole series looks good to me, thanks for improving the commit 
messages, it helps process the changes better. I like the end result, 
and it gets us some good ability without too much cost in size.


Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Thanks,
Jake

> v1: https://lore.kernel.org/all/20221018230728.1039524-1-kuba@kernel.org/
> 
> Jakub Kicinski (13):
>    genetlink: refactor the cmd <> policy mapping dump
>    genetlink: move the private fields in struct genl_family
>    genetlink: introduce split op representation
>    genetlink: load policy based on validation flags
>    genetlink: check for callback type at op load time
>    genetlink: add policies for both doit and dumpit in
>      ctrl_dumppolicy_start()
>    genetlink: support split policies in ctrl_dumppolicy_put_op()
>    genetlink: inline genl_get_cmd()
>    genetlink: add iterator for walking family ops
>    genetlink: use iterator in the op to policy map dumping
>    genetlink: inline old iteration helpers
>    genetlink: allow families to use split ops directly
>    genetlink: convert control family to split ops
> 
>   include/net/genetlink.h   |  76 +++++-
>   net/batman-adv/netlink.c  |   6 +-
>   net/core/devlink.c        |   4 +-
>   net/core/drop_monitor.c   |   4 +-
>   net/ieee802154/nl802154.c |   6 +-
>   net/netlink/genetlink.c   | 473 ++++++++++++++++++++++++++++----------
>   net/wireless/nl80211.c    |   6 +-
>   7 files changed, 433 insertions(+), 142 deletions(-)
>