netdev - Re: [RFC PATCH v1 3/3] liburing: add test programs for napi busy poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9761f0b-0a31-1ec9-66b8-371cb22250f9@gnuweeb.org>
Date:   Fri, 4 Nov 2022 05:04:16 +0700
From:   Ammar Faizi <ammarfaizi2@...weeb.org>
To:     Stefan Roesch <shr@...kernel.io>,
        Facebook Kernel Team <kernel-team@...com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Olivier Langlois <olivier@...llion01.com>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev Mailing List <netdev@...r.kernel.org>,
        io-uring Mailing List <io-uring@...r.kernel.org>
Subject: Re: [RFC PATCH v1 3/3] liburing: add test programs for napi busy poll

On 11/4/22 3:40 AM, Stefan Roesch wrote:
> +struct option longopts[] =
> +{
> +        {"address"  , 1, NULL, 'a'},
> +        {"busy"     , 0, NULL, 'b'},
> +        {"help"     , 0, NULL, 'h'},
> +        {"num_pings", 1, NULL, 'n'},
> +        {"port"     , 1, NULL, 'p'},
> +        {"sqpoll"   , 0, NULL, 's'},
> +	{"timeout"  , 1, NULL, 't'},

Inconsistent indentation.

> +	if (strlen(opt.addr) == 0) {
> +		fprintf(stderr, "address option is mandatory\n");
> +		printUsage(argv[0]);
> +		exit(-1);
> +	}
Don't use integer literal like 0 or -1 as the exit code in tests, use the
exit code protocol:

   T_EXIT_PASS
   T_EXIT_FAIL
   T_EXIT_SKIP

They are defined in test/helpers.h.

-- 
Ammar Faizi