netdev - Re: [PATCH net-next] ethtool: add netlink based get rxfh support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2Q/gmS0v8i6SNi4@lunn.ch>
Date:   Thu, 3 Nov 2022 23:24:02 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Sudheer Mogilappagari <sudheer.mogilappagari@...el.com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, corbet@....net,
        mkubecek@...e.cz, sridhar.samudrala@...el.com,
        anthony.l.nguyen@...el.com
Subject: Re: [PATCH net-next] ethtool: add netlink based get rxfh support

> +static int rxfh_prepare_data(const struct ethnl_req_info *req_base,
> +			     struct ethnl_reply_data *reply_base,
> +			     struct genl_info *info)
> +{

...

> +
> +	ret = ethnl_ops_begin(dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	/* Some drivers don't handle rss_context */
> +	if (rxfh->rss_context && !ops->get_rxfh_context)
> +		return -EOPNOTSUPP;

You called ethnl_ops_begin(). Just returning here is going to mess up
rumtime power control, and any driver which expects is
ethtool_ops->complete() call to be called.

	Andrew