netdev - Re: [PATCH] sfc (gcc13): synchronize ef100_enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166744741893.12191.4306844598535321397.git-patchwork-notify@kernel.org>
Date:   Thu, 03 Nov 2022 03:50:18 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Jiri Slaby <jirislaby@...nel.org>
Cc:     ecree.xilinx@...il.com, linux-kernel@...r.kernel.org,
        mliska@...e.cz, habetsm.xilinx@...il.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] sfc (gcc13): synchronize ef100_enqueue_skb()'s return type

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 31 Oct 2022 12:44:40 +0100 you wrote:
> ef100_enqueue_skb() generates a valid warning with gcc-13:
>   drivers/net/ethernet/sfc/ef100_tx.c:370:5: error: conflicting types for 'ef100_enqueue_skb' due to enum/integer mismatch; have 'int(struct efx_tx_queue *, struct sk_buff *)'
>   drivers/net/ethernet/sfc/ef100_tx.h:25:13: note: previous declaration of 'ef100_enqueue_skb' with type 'netdev_tx_t(struct efx_tx_queue *, struct sk_buff *)'
> 
> I.e. the type of the ef100_enqueue_skb()'s return value in the declaration is
> int, while the definition spells enum netdev_tx_t. Synchronize them to the
> latter.
> 
> [...]

Here is the summary with links:
  - sfc (gcc13): synchronize ef100_enqueue_skb()'s return type
    https://git.kernel.org/netdev/net-next/c/3319dbb3e755

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html