netdev - Re: [PATCH net-next] net/core: Allow live renaming when an interface is up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Nov 2022 19:19:58 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Andy Ren <andy.ren@...cruise.com>
Cc:     netdev@...r.kernel.org, richardbgobert@...il.com,
        davem@...emloft.net, wsa+renesas@...g-engineering.com,
        edumazet@...gle.com, petrm@...dia.com, kuba@...nel.org,
        pabeni@...hat.com, corbet@....net, andrew@...n.ch,
        dsahern@...il.com, sthemmin@...rosoft.com, idosch@...sch.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        roman.gushchin@...ux.dev
Subject: Re: [PATCH net-next] net/core: Allow live renaming when an
 interface is up

On Thu,  3 Nov 2022 16:58:47 -0700
Andy Ren <andy.ren@...cruise.com> wrote:

> @@ -1691,7 +1690,6 @@ enum netdev_priv_flags {
>  	IFF_FAILOVER			= 1<<27,
>  	IFF_FAILOVER_SLAVE		= 1<<28,
>  	IFF_L3MDEV_RX_HANDLER		= 1<<29,
> -	IFF_LIVE_RENAME_OK		= 1<<30,
>  	IFF_TX_SKB_NO_LINEAR		= BIT_ULL(31),
>  	IFF_CHANGE_PROTO_DOWN		= BIT_ULL(32),
>  };

It helps with developers memory if you change the line to something like:
	/* was IFF_RENAME_OK */