netdev - Re: [PATCH net-next 4/4] net: dsa: remove phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221104153346.776wommuamwawvwr@skbuf>
Date:   Fri, 4 Nov 2022 15:33:46 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
CC:     Florian Fainelli <f.fainelli@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Sean Anderson <sean.anderson@...o.com>,
        Colin Foster <colin.foster@...advantage.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 4/4] net: dsa: remove phylink_validate() method

On Fri, Nov 04, 2022 at 02:48:11PM +0000, Russell King (Oracle) wrote:
> > > > However, I don't exactly understand your choice of fixing this
> > > > inconsistency (by providing a phylink_validate method). Why don't you
> > > > simply set MAC_ASYM_PAUSE | MAC_SYM_PAUSE in config->mac_capabilities
> > > > from within bcm_sf2_sw_get_caps(), only if we know this is an xMII port
> > > > (and not for MoCA and internal PHYs)? Then, phylink_generic_validate()
> > > > would know to exclude the "pause" link modes, right?
> > > 
> > > bcm_sf2_sw_get_caps() doesn't have visibility of which interface mode
> > > will be used.
> > 
> > Update your tree, commit 4d2f6dde4daa ("net: dsa: bcm_sf2: Have PHYLINK
> > configure CPU/IMP port(s)") has appeared in net-next and now the check
> > in mac_link_up() is for phy_interface_is_rgmii().
> 
> Great, one less fixme. Still a couple remaining open.

True.

However, do you agree that phylink_validate() is no longer a contention
point, and that now you can rework your fixup to be localized to
bcm_sf2_sw_get_caps(), which frees up the possibility for me to remove
ds->ops->phylink_validate()?