netdev - Re: [PATCH net-next v7 5/5] ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Nov 2022 17:36:52 +0100
From:   Maxime Chevallier <maxime.chevallier@...tlin.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Luka Perkov <luka.perkov@...tura.hr>,
        Robert Marko <robert.marko@...tura.hr>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>
Subject: Re: [PATCH net-next v7 5/5] ARM: dts: qcom: ipq4019: Add
 description for the IPQESS Ethernet controller

Hello Krzysztof, Vladimir,

On Fri, 4 Nov 2022 15:40:48 +0000
Vladimir Oltean <vladimir.oltean@....com> wrote:

> On Fri, Nov 04, 2022 at 11:08:07AM -0400, Krzysztof Kozlowski wrote:
> > On 04/11/2022 10:32, Vladimir Oltean wrote:  
> > > On Fri, Nov 04, 2022 at 10:31:06AM -0400, Krzysztof Kozlowski
> > > wrote:  
> > >>> diff --git a/arch/arm/boot/dts/qcom-ipq4019.dtsi
> > >>> b/arch/arm/boot/dts/qcom-ipq4019.dtsi index
> > >>> b23591110bd2..5fa1af147df9 100644 ---
> > >>> a/arch/arm/boot/dts/qcom-ipq4019.dtsi +++
> > >>> b/arch/arm/boot/dts/qcom-ipq4019.dtsi @@ -38,6 +38,7 @@ aliases
> > >>> { spi1 = &blsp1_spi2;
> > >>>  		i2c0 = &blsp1_i2c3;
> > >>>  		i2c1 = &blsp1_i2c4;
> > >>> +		ethernet0 = &gmac;  
> > >>
> > >> Hm, I have doubts about this one. Why alias is needed and why it
> > >> is a property of a SoC? Not every board has Ethernet enabled, so
> > >> this looks like board property.
> > >>
> > >> I also wonder why do you need it at all?  
> > > 
> > > In general, Ethernet aliases are needed so that the bootloader
> > > can fix up the MAC address of each port's OF node with values it
> > > gets from the U-Boot environment or an AT24 EEPROM or something
> > > like that.  
> > 
> > Assuming that's the case here, my other part of question remains -
> > is this property of SoC or board? The buses (SPI, I2C) are
> > properties of boards, even though were incorrectly put here. If the
> > board has multiple ethernets, the final ordering is the property of
> > the board, not SoC. I would assume that bootloader also configures
> > the MAC address based on the board config, not per SoC...  
> 
> I don't disagree. On NXP LS1028A, we also have all aliases in board
> device trees and not in the SoC dtsi.

You're right indeed, it was put there so that it's alongside the other
aliases, but it makes more sense to include it in the board file. I'll
respin with the alias removed.

Thanks,

Maxime