netdev - Re: [PATCH net-next] ethtool: add netlink based get rxfh support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2VrAh4hha0y95Lv@lunn.ch>
Date:   Fri, 4 Nov 2022 20:41:54 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     "Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "corbet@....net" <corbet@....net>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: Re: [PATCH net-next] ethtool: add netlink based get rxfh support

> Got a question wrt rtnl_lock usage. I see lock is acquired for SET
> operations and not for GET operations. Is rtnl_lock needed in this
> case due to slightly different flow than rest of GET ops?

The ioctl path takes the lock, so i don't see why the netlink code
should not take the lock.

       Andrew