netdev - Re: [net 06/11] net/mlx5e: Add missing sanity checks for max TX WQE size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221103211202.42abcfe9@kernel.org>
Date:   Thu, 3 Nov 2022 21:12:02 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Maxim Mikityanskiy <maximmi@...dia.com>
Subject: Re: [net 06/11] net/mlx5e: Add missing sanity checks for max TX WQE
 size

On Wed,  2 Nov 2022 23:55:42 -0700 Saeed Mahameed wrote:
> From: Maxim Mikityanskiy <maximmi@...dia.com>
> 
> The commit cited below started using the firmware capability for the
> maximum TX WQE size. This commit adds an important check to verify that
> the driver doesn't attempt to exceed this capability, and also restores
> another check mistakenly removed in the cited commit (a WQE must not
> exceed the page size).
> 
> Fixes: c27bd1718c06 ("net/mlx5e: Read max WQEBBs on the SQ from firmware")
> Signed-off-by: Maxim Mikityanskiy <maximmi@...dia.com>
> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

32bit is not on board:

drivers/net/ethernet/mellanox/mlx5/core/en_tx.c:323:72: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘unsigned int’ [-Wformat=]
  323 |                         netdev_warn(skb->dev, "ds_cnt_inl = %u > max %lu\n",
      |                                                                      ~~^
      |                                                                        |
      |                                                                        long unsigned int
      |                                                                      %u