lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Nov 2022 14:13:14 -0700 From: Linus Torvalds <torvalds@...ux-foundation.org> To: "Jason A. Donenfeld" <Jason@...c4.com> Cc: Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>, Stephen Boyd <sboyd@...nel.org>, Guenter Roeck <linux@...ck-us.net>, Anna-Maria Gleixner <anna-maria@...utronix.de>, Andrew Morton <akpm@...ux-foundation.org>, rcu@...r.kernel.org, linux-doc@...r.kernel.org, linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, linux-edac@...r.kernel.org, cgroups@...r.kernel.org, linux-block@...r.kernel.org, linux-acpi@...r.kernel.org, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-pm@...r.kernel.org, drbd-dev@...ts.linbit.com, linux-bluetooth@...r.kernel.org, openipmi-developer@...ts.sourceforge.net, linux-media@...r.kernel.org, dri-devel@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org, intel-gfx@...ts.freedesktop.org, linux-input@...r.kernel.org, linux-parisc@...r.kernel.org, linux-leds@...r.kernel.org, intel-wired-lan@...ts.osuosl.org, linux-usb@...r.kernel.org, linux-wireless@...r.kernel.org, linux-scsi@...r.kernel.org, linux-staging@...ts.linux.dev, linux-ext4@...r.kernel.org, linux-nilfs@...r.kernel.org, bridge@...ts.linux-foundation.org, netfilter-devel@...r.kernel.org, coreteam@...filter.org, lvs-devel@...r.kernel.org, linux-afs@...ts.infradead.org, linux-nfs@...r.kernel.org, tipc-discussion@...ts.sourceforge.net, alsa-devel@...a-project.org Subject: Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers On Sat, Nov 5, 2022 at 2:03 PM Jason A. Donenfeld <Jason@...c4.com> wrote: > > Something that might help here is changing the `...` into > `... when exists` or into `... when != ptr` or similar. I actually tried that. You don't want "when exists", you'd want "when forall", but that seems to be the default. And trying "when != ptr->timer" actually does the right thing in that it gets rid of the case where the timer is modified outside of the del_timer() case, *but* it also causes odd other changes to the output. Look at what it generates for that drivers/media/usb/pvrusb2/pvrusb2-hdw.c file, which finds a lot of triggers with the "when != ptr->timer", but only does one without it. So I gave up, just because I clearly don't understand the rules. (Comparing output is also fun because the ordering of the patches is random, so consecutive runs with the same rule will give different patches. I assume that it's just because it's done in parallel, but it doesn't help the "try to see what changes when you change the script" ;) Linus
Powered by blists - more mailing lists