netdev - Re: [PATCH v1 net-next 3/6] udp: Set NULL to udp_seq_afinfo.udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 5 Nov 2022 11:04:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: Re: [PATCH v1 net-next 3/6] udp: Set NULL to
 udp_seq_afinfo.udp_table.

Hi Kuniyuki,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Kuniyuki-Iwashima/udp-Introduce-optional-per-netns-hash-table/20221105-031106
patch link:    https://lore.kernel.org/r/20221104190612.24206-4-kuniyu%40amazon.com
patch subject: [PATCH v1 net-next 3/6] udp: Set NULL to udp_seq_afinfo.udp_table.
config: nios2-randconfig-r002-20221104
compiler: nios2-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/49362b402f7edf31637443640ee33de9c3506260
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Kuniyuki-Iwashima/udp-Introduce-optional-per-netns-hash-table/20221105-031106
        git checkout 49362b402f7edf31637443640ee33de9c3506260
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash net/ipv4/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

>> net/ipv4/udp.c:139:54: warning: 'struct udp_seq_afinfo' declared inside parameter list will not be visible outside of this definition or declaration
     139 | static struct udp_table *udp_get_table_afinfo(struct udp_seq_afinfo *afinfo,
         |                                                      ^~~~~~~~~~~~~~
   net/ipv4/udp.c: In function 'udp_get_table_afinfo':
>> net/ipv4/udp.c:142:22: error: invalid use of undefined type 'struct udp_seq_afinfo'
     142 |         return afinfo->udp_table ? : net->ipv4.udp_table;
         |                      ^~
   net/ipv4/udp.c: At top level:
   net/ipv4/udp.c:139:26: warning: 'udp_get_table_afinfo' defined but not used [-Wunused-function]
     139 | static struct udp_table *udp_get_table_afinfo(struct udp_seq_afinfo *afinfo,
         |                          ^~~~~~~~~~~~~~~~~~~~


vim +142 net/ipv4/udp.c

   138	
 > 139	static struct udp_table *udp_get_table_afinfo(struct udp_seq_afinfo *afinfo,
   140						      struct net *net)
   141	{
 > 142		return afinfo->udp_table ? : net->ipv4.udp_table;
   143	}
   144	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (137902 bytes)