netdev - Re: [PATCH net-next v3 0/3] nfp: IPsec offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221105152708.GB2602992@gauss3.secunet.de>
Date:   Sat, 5 Nov 2022 16:27:08 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Simon Horman <simon.horman@...igine.com>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Leon Romanovsky <leon@...nel.org>,
        "Chentian Liu" <chengtian.liu@...igine.com>,
        Huanhuan Wang <huanhuan.wang@...igine.com>,
        Yinjun Zhang <yinjun.zhang@...igine.com>,
        Louis Peens <louis.peens@...igine.com>,
        <netdev@...r.kernel.org>, <oss-drivers@...igine.com>
Subject: Re: [PATCH net-next v3 0/3] nfp: IPsec offload support

On Thu, Nov 03, 2022 at 08:48:00PM -0700, Jakub Kicinski wrote:
> On Tue,  1 Nov 2022 12:02:45 +0100 Simon Horman wrote:
> > It covers three enhancements:
> > 
> > 1. Patches 1/3:
> >    - Extend the capability word and control word to to support
> >      new features.
> > 
> > 2. Patch 2/3:
> >    - Add framework to support IPsec offloading for NFP driver,
> >      but IPsec offload control plane interface xfrm callbacks which
> >      interact with upper layer are not implemented in this patch.
> > 
> > 3. Patch 3/3:
> >    - IPsec control plane interface xfrm callbacks are implemented
> >      in this patch.
> 
> Steffen, Leon, does this look good to you?

The xfrm offload API is used correct, but can't speak
for the driver code.

For the xfrm API related part:

Acked-by: Steffen Klassert <steffen.klassert@...unet.com>