netdev - Re: [RFC PATCH v1 3/3] liburing: add test programs for napi busy poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <qvqwmt92abow.fsf@dev0134.prn3.facebook.com>
Date:   Mon, 07 Nov 2022 09:58:05 -0800
From:   Stefan Roesch <shr@...kernel.io>
To:     Ammar Faizi <ammarfaizi2@...weeb.org>
Cc:     Facebook Kernel Team <kernel-team@...com>,
        Jens Axboe <axboe@...nel.dk>,
        Olivier Langlois <olivier@...llion01.com>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev Mailing List <netdev@...r.kernel.org>,
        io-uring Mailing List <io-uring@...r.kernel.org>
Subject: Re: [RFC PATCH v1 3/3] liburing: add test programs for napi busy poll


Ammar Faizi <ammarfaizi2@...weeb.org> writes:

> On 11/4/22 3:40 AM, Stefan Roesch wrote:
>> +void *encodeUserData(char type, int fd)
>> +{
>> +	return (void *)((uint32_t)fd | ((__u64)type << 56));
>> +}
> This breaks 32-bit build.
>
>   i686-linux-gnu-gcc -Werror -D_GNU_SOURCE -D__SANE_USERSPACE_TYPES__ -I../src/include/ -include ../config-host.h -g -O3 -Wall -Wextra -Werror -Wno-unused-parameter -Wno-sign-compare -Wstringop-overflow=0 -Warray-bounds=0 -DLIBURING_BUILD_TEST -o napi-busy-poll-client.t napi-busy-poll-client.c helpers.o -L../src/ -luring -lpthread
>   napi-busy-poll-client.c: In function ‘encodeUserData’:
>   napi-busy-poll-client.c:119:16: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>     119 |         return (void *)((uint32_t)fd | ((__u64)type << 56));
>         |                ^
>   cc1: all warnings being treated as errors
>

Version 2 of the patch fixes the above problem.