netdev - Re: [PATCH] net: broadcom: Fix BCMGENET Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Nov 2022 12:43:18 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        richardcochran@...il.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: broadcom: Fix BCMGENET Kconfig

On 11/5/22 02:02, YueHaibing wrote:
> While BCMGENET select BROADCOM_PHY as y, but PTP_1588_CLOCK_OPTIONAL is m,
> kconfig warning and build errors:
> 
> WARNING: unmet direct dependencies detected for BROADCOM_PHY
>    Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
>    Selected by [y]:
>    - BCMGENET [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_BROADCOM [=y] && HAS_IOMEM [=y] && ARCH_BCM2835 [=y]
> 
> drivers/net/phy/broadcom.o: In function `bcm54xx_suspend':
> broadcom.c:(.text+0x6ac): undefined reference to `bcm_ptp_stop'
> drivers/net/phy/broadcom.o: In function `bcm54xx_phy_probe':
> broadcom.c:(.text+0x784): undefined reference to `bcm_ptp_probe'
> drivers/net/phy/broadcom.o: In function `bcm54xx_config_init':
> broadcom.c:(.text+0xd4c): undefined reference to `bcm_ptp_config_init'
> 
> Fixes: 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET")
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Florian Fainelli <f.fainelli@...adcom.com>

Thanks
-- 
Florian