netdev - Re: [PATCHv3 iproute2-next] rtnetlink: add new function rtnl_echo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2pO5jXPgxJLIN9S@Laptop-X1>
Date:   Tue, 8 Nov 2022 20:43:18 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     netdev@...r.kernel.org, Guillaume Nault <gnault@...hat.com>,
        David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCHv3 iproute2-next] rtnetlink: add new function
 rtnl_echo_talk()

On Tue, Nov 08, 2022 at 11:40:06AM +0200, Ido Schimmel wrote:
> > I can fix this either in iproute2 or in the selftests.
> > I'd perfer ask David's opinion.
> 
> Sure, but note that:
> 
> 1. Other than the 4 selftests that we know about and can easily patch,
> there might be a lot of other applications that invoke iproute2 and
> expect this return code. It is used by iproute2 since at least 2004.
> 
> 2. There is already precedence for restoring the original code. See
> commit d58ba4ba2a53 ("ip: return correct exit code on route failure").

OK, I will post a iproute fix first. If David or others has comments.
Please just NACK the new patch.

Thanks
Hangbin