netdev - Re: [PATCH net-next v9 1/9] devlink: Introduce new attribute 'tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfaddfeb-7159-98e4-f6c1-ae18e4ed31e1@intel.com>
Date:   Tue, 8 Nov 2022 08:48:51 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Michal Wilczynski <michal.wilczynski@...el.com>
CC:     <netdev@...r.kernel.org>, <alexandr.lobakin@...el.com>,
        <jesse.brandeburg@...el.com>, <przemyslaw.kitszel@...el.com>,
        <anthony.l.nguyen@...el.com>, <ecree.xilinx@...il.com>,
        <jiri@...nulli.us>
Subject: Re: [PATCH net-next v9 1/9] devlink: Introduce new attribute
 'tx_priority' to devlink-rate



On 11/4/2022 7:10 PM, Jakub Kicinski wrote:
> On Fri,  4 Nov 2022 15:30:54 +0100 Michal Wilczynski wrote:
>> +		if (attrs[DEVLINK_ATTR_RATE_TX_PRIORITY] && !ops->rate_leaf_tx_priority_set) {
>> +			NL_SET_ERR_MSG_MOD(info->extack,
>> +					   "TX priority set isn't supported for the leafs");
> 
> Please point to the attribute - NL_SET_ERR_MSG_ATTR().
> 
> I'm not entirely sure why we keep slapping the _MOD() on the extacks,
> but if you care to keep that you may need to add the _MOD flavor of
> the above.

_MOD is useful in driver code because it will indicate that it came from 
a given driver module, but I don't think its useful in the core devlink 
or other networking files.