netdev - Re: [PATCH net-next RFC 1/5] net: move back netif_set_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2qRjp9TS9Ek4t81@kroah.com>
Date:   Tue, 8 Nov 2022 18:27:42 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Albert Zhou <albert.zhou.50@...il.com>
Cc:     linux-usb@...r.kernel.org, nic_swsd@...ltek.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next RFC 1/5] net: move back netif_set_gso_max helpers

On Wed, Nov 09, 2022 at 02:33:38AM +1100, Albert Zhou wrote:
> Reverse commit 744d49daf8bd ("net: move netif_set_gso_max helpers") by
> moving the functions netif_set_gso_max* back to netdevice.h so that the
> updated R8152 v2 driver can use them.
> 
> Signed-off-by: Albert Zhou <albert.zhou.50@...il.com>
> ---
>  include/linux/netdevice.h | 21 +++++++++++++++++++++
>  net/core/dev.h            | 21 ---------------------
>  2 files changed, 21 insertions(+), 21 deletions(-)

No, use the helpers that are there to be used instead.  This should not
be needed to be done, fix up the driver you are adding instead.

thanks,

greg k-h