netdev - Re: [PATCH net-next 01/15] bridge: switchdev: Let device drivers determine FDB offload indication

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31C46FC0-3ABB-4FD1-B44B-D467C81C6340@blackwall.org>
Date:   Tue, 08 Nov 2022 14:01:17 -0400
From:   Nikolay Aleksandrov <razor@...ckwall.org>
To:     Petr Machata <petrm@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Ivan Vecera <ivecera@...hat.com>, netdev@...r.kernel.org
CC:     Roopa Prabhu <roopa@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        bridge@...ts.linux-foundation.org,
        Ido Schimmel <idosch@...dia.com>,
        "Hans J . Schultz" <netdev@...io-technology.com>, mlxsw@...dia.com
Subject: Re: [PATCH net-next 01/15] bridge: switchdev: Let device drivers determine FDB offload indication

On 8 November 2022 06:47:07 GMT-04:00, Petr Machata <petrm@...dia.com> wrote:
>From: Ido Schimmel <idosch@...dia.com>
>
>Currently, FDB entries that are notified to the bridge via
>'SWITCHDEV_FDB_ADD_TO_BRIDGE' are always marked as offloaded. With MAB
>enabled, this will no longer be universally true. Device drivers will
>report locked FDB entries to the bridge to let it know that the
>corresponding hosts required authorization, but it does not mean that
>these entries are necessarily programmed in the underlying hardware.
>
>Solve this by determining the offload indication based of the
>'offloaded' bit in the FDB notification.
>
>Signed-off-by: Ido Schimmel <idosch@...dia.com>
>Reviewed-by: Petr Machata <petrm@...dia.com>
>Signed-off-by: Petr Machata <petrm@...dia.com>
>---
> net/bridge/br.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>

>diff --git a/net/bridge/br.c b/net/bridge/br.c
>index 96e91d69a9a8..145999b8c355 100644
>--- a/net/bridge/br.c
>+++ b/net/bridge/br.c
>@@ -172,7 +172,7 @@ static int br_switchdev_event(struct notifier_block *unused,
> 			break;
> 		}
> 		br_fdb_offloaded_set(br, p, fdb_info->addr,
>-				     fdb_info->vid, true);
>+				     fdb_info->vid, fdb_info->offloaded);
> 		break;
> 	case SWITCHDEV_FDB_DEL_TO_BRIDGE:
> 		fdb_info = ptr;