netdev - Re: [PATCH net-next RFC 0/5] Update r8152 to version two

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221108125028.35a765be@kernel.org>
Date:   Tue, 8 Nov 2022 12:50:28 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Albert Zhou <albert.zhou.50@...il.com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        nic_swsd@...ltek.com, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next RFC 0/5] Update r8152 to version two

On Wed,  9 Nov 2022 02:33:37 +1100 Albert Zhou wrote:
> This patch integrates the version-two r8152 drivers from Realtek into
> the kernel. I am new to kernel development, so apologies if I make
> newbie mistakes.
> 
> I have tested the updated module in v6.1 on my machine, without any
> issues.

What are you trying to achieve? Copy pasting 18k LoC into the kernel 
in a single patch is definitely not the way we do development. If there
are features missing in the upstream driver, or you see discrepancies
in the operation - please prepare targeted patches.