netdev - RE: [Patch v10 01/12] net: mana: Add support for auxiliary device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR21MB3263700CCC9EC16FF7EA937BCE3F9@PH7PR21MB3263.namprd21.prod.outlook.com>
Date:   Tue, 8 Nov 2022 21:33:21 +0000
From:   Long Li <longli@...rosoft.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "shiraz.saleem@...el.com" <shiraz.saleem@...el.com>,
        Ajay Sharma <sharmaajay@...rosoft.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: RE: [Patch v10 01/12] net: mana: Add support for auxiliary device


> > int mana_probe(struct gdma_dev *gd, bool resuming)
> >  				break;
> >  		}
> >  	}
> > +
> > +	err = add_adev(gd);
> >  out:
> >  	if (err)
> >  		mana_remove(gd, false);
> > @@ -2189,6 +2267,10 @@ void mana_remove(struct gdma_dev *gd, bool
> suspending)
> >  	int err;
> >  	int i;
> >
> > +	/* adev currently doesn't support suspending, always remove it */
> > +	if (gd->adev)
> 
> This condition is always true, isn't it?

I think the check is necessary. mana_probe() will call mana_remove() if it fails to
add this adev to gd. If this is the case, we can't call remove_adev().

Thanks,
Long