netdev - Re: [PATCH net-next 03/11] sfc: add ability for extra channels to receive raw RX buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202211090628.yF1YYvd9-lkp@intel.com>
Date:   Wed, 9 Nov 2022 06:20:23 +0800
From:   kernel test robot <lkp@...el.com>
To:     edward.cree@....com, netdev@...r.kernel.org,
        linux-net-drivers@....com
Cc:     oe-kbuild-all@...ts.linux.dev, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
        habetsm.xilinx@...il.com, Edward Cree <ecree.xilinx@...il.com>
Subject: Re: [PATCH net-next 03/11] sfc: add ability for extra channels to
 receive raw RX buffers

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/edward-cree-amd-com/sfc-TC-offload-counters/20221109-012812
patch link:    https://lore.kernel.org/r/50ecccc725b9481c79f89e8dbd0eac9d043ce4a1.1667923490.git.ecree.xilinx%40gmail.com
patch subject: [PATCH net-next 03/11] sfc: add ability for extra channels to receive raw RX buffers
config: powerpc-allyesconfig
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/ea3ad411cc0881921d2b9f7a801c11d87dfccdc2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review edward-cree-amd-com/sfc-TC-offload-counters/20221109-012812
        git checkout ea3ad411cc0881921d2b9f7a801c11d87dfccdc2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/net/ethernet/sfc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/sfc/ef100_rx.c: In function '__ef100_rx_packet':
>> drivers/net/ethernet/sfc/ef100_rx.c:24:39: warning: left shift count >= width of type [-Wshift-count-overflow]
      24 | #define PREFIX_WIDTH_MASK(_f)   ((1UL << ESF_GZ_RX_PREFIX_ ## _f ## _WIDTH) - 1)
         |                                       ^~
   drivers/net/ethernet/sfc/ef100_rx.c:27:34: note: in expansion of macro 'PREFIX_WIDTH_MASK'
      27 |                                  PREFIX_WIDTH_MASK(_f))
         |                                  ^~~~~~~~~~~~~~~~~
   drivers/net/ethernet/sfc/ef100_rx.c:71:28: note: in expansion of macro 'PREFIX_FIELD'
      71 |                 u32 mark = PREFIX_FIELD(prefix, USER_MARK);
         |                            ^~~~~~~~~~~~


vim +24 drivers/net/ethernet/sfc/ef100_rx.c

51b35a454efdcd Edward Cree 2020-07-27  20  
8e57daf70671e4 Edward Cree 2020-08-03  21  /* Get the value of a field in the RX prefix */
8e57daf70671e4 Edward Cree 2020-08-03  22  #define PREFIX_OFFSET_W(_f)	(ESF_GZ_RX_PREFIX_ ## _f ## _LBN / 32)
8e57daf70671e4 Edward Cree 2020-08-03  23  #define PREFIX_OFFSET_B(_f)	(ESF_GZ_RX_PREFIX_ ## _f ## _LBN % 32)
8e57daf70671e4 Edward Cree 2020-08-03 @24  #define PREFIX_WIDTH_MASK(_f)	((1UL << ESF_GZ_RX_PREFIX_ ## _f ## _WIDTH) - 1)
8e57daf70671e4 Edward Cree 2020-08-03  25  #define PREFIX_WORD(_p, _f)	le32_to_cpu((__force __le32)(_p)[PREFIX_OFFSET_W(_f)])
8e57daf70671e4 Edward Cree 2020-08-03  26  #define PREFIX_FIELD(_p, _f)	((PREFIX_WORD(_p, _f) >> PREFIX_OFFSET_B(_f)) & \
8e57daf70671e4 Edward Cree 2020-08-03  27  				 PREFIX_WIDTH_MASK(_f))
965b549f3c20db Edward Cree 2020-07-27  28  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (329854 bytes)