netdev - Re: [RFC PATCH v2 1/4] liburing: add api to set napi busy poll timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b507be5c-1669-57ee-d16e-964e326309f9@gnuweeb.org>
Date:   Tue, 8 Nov 2022 14:14:56 +0700
From:   Ammar Faizi <ammarfaizi2@...weeb.org>
To:     Stefan Roesch <shr@...kernel.io>,
        Facebook Kernel Team <kernel-team@...com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Olivier Langlois <olivier@...llion01.com>,
        netdev Mailing List <netdev@...r.kernel.org>,
        io-uring Mailing List <io-uring@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [RFC PATCH v2 1/4] liburing: add api to set napi busy poll
 timeout

On 11/8/22 12:53 AM, Stefan Roesch wrote:
> diff --git a/src/liburing.map b/src/liburing.map
> index 06c64f8..793766e 100644
> --- a/src/liburing.map
> +++ b/src/liburing.map
> @@ -60,6 +60,8 @@ LIBURING_2.3 {
>   	global:
>   		io_uring_register_sync_cancel;
>   		io_uring_register_file_alloc_range;
> +		io_uring_register_busy_poll_timeout;
> +		io_uring_unregister_busy_poll_timeout;
>   		io_uring_enter;
>   		io_uring_enter2;
>   		io_uring_setup;
> @@ -67,3 +69,9 @@ LIBURING_2.3 {
>   		io_uring_get_events;
>   		io_uring_submit_and_get_events;
>   } LIBURING_2.2;

I don't understand this part. You add:

     io_uring_register_busy_poll_timeout
     io_uring_unregister_busy_poll_timeout

in the LIBURING_2.3 section.

What are they? I don't find their declaration and definition.

How do they differ from:

     io_uring_napi_register_busy_poll_timeout
     io_uring_napi_unregister_busy_poll_timeout

that you add in the LIBURING_2.4 section?

-- 
Ammar Faizi