lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 Nov 2022 07:41:11 +0000 (UTC) From: Kalle Valo <kvalo@...nel.org> To: Marek Vasut <marex@...x.de> Cc: linux-wireless@...r.kernel.org, Marek Vasut <marex@...x.de>, Amitkumar Karwar <amit.karwar@...pinesignals.com>, Angus Ainslie <angus@...ea.ca>, Jakub Kicinski <kuba@...nel.org>, Johannes Berg <johannes@...solutions.net>, Martin Fuzzey <martin.fuzzey@...wbird.group>, Martin Kepplinger <martink@...teo.de>, Prameela Rani Garnepudi <prameela.j04cs@...il.com>, Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>, Siva Rebbagondla <siva8118@...il.com>, netdev@...r.kernel.org Subject: Re: [PATCH v5] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via control port Marek Vasut <marex@...x.de> wrote: > When using wpa_supplicant v2.10, this driver is no longer able to > associate with any AP and fails in the EAPOL 4-way handshake while > sending the 2/4 message to the AP. The problem is not present in > wpa_supplicant v2.9 or older. The problem stems from HostAP commit > 144314eaa ("wpa_supplicant: Send EAPOL frames over nl80211 where available") > which changes the way EAPOL frames are sent, from them being send > at L2 frames to them being sent via nl80211 control port. > > An EAPOL frame sent as L2 frame is passed to the WiFi driver with > skb->protocol ETH_P_PAE, while EAPOL frame sent via nl80211 control > port has skb->protocol set to ETH_P_802_3 . The later happens in > ieee80211_tx_control_port(), where the EAPOL frame is encapsulated > into 802.3 frame. > > The rsi_91x driver handles ETH_P_PAE EAPOL frames as high-priority > frames and sends them via highest-priority transmit queue, while > the ETH_P_802_3 frames are sent as regular frames. The EAPOL 4-way > handshake frames must be sent as highest-priority, otherwise the > 4-way handshake times out. > > Therefore, to fix this problem, inspect the skb control flags and > if flag IEEE80211_TX_CTRL_PORT_CTRL_PROTO is set, assume this is > an EAPOL frame and transmit the frame via high-priority queue just > like other ETH_P_PAE frames. > > Fixes: 0eb42586cf87 ("rsi: data packet descriptor enhancements") > Signed-off-by: Marek Vasut <marex@...x.de> Patch applied to wireless-next.git, thanks. b8f6efccbb9d wifi: rsi: Fix handling of 802.3 EAPOL frames sent via control port -- https://patchwork.kernel.org/project/linux-wireless/patch/20221104163339.227432-1-marex@denx.de/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists