netdev - Re: [PATCH v2 bpf-next 0/3] bpf: Add hwtstamp field for the sockops prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95ef48cc-fc12-74d4-702f-45754c508a85@meta.com>
Date:   Mon, 7 Nov 2022 17:03:09 -0800
From:   Yonghong Song <yhs@...a.com>
To:     Martin KaFai Lau <martin.lau@...ux.dev>, bpf@...r.kernel.org
Cc:     'Alexei Starovoitov ' <ast@...nel.org>,
        'Andrii Nakryiko ' <andrii@...nel.org>,
        'Daniel Borkmann ' <daniel@...earbox.net>,
        netdev@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH v2 bpf-next 0/3] bpf: Add hwtstamp field for the sockops
 prog



On 11/7/22 3:04 PM, Martin KaFai Lau wrote:
> From: Martin KaFai Lau <martin.lau@...nel.org>
> 
> The bpf-tc prog has already been able to access the
> skb_hwtstamps(skb)->hwtstamp.  This set extends the same hwtstamp
> access to the sockops prog.
> 
> v2:
> - Fixed the btf_dump selftest which depends on the
>    last member of 'struct bpf_sock_ops'.
> 
> Martin KaFai Lau (3):
>    bpf: Add hwtstamp field for the sockops prog
>    selftests/bpf: Fix incorrect ASSERT in the tcp_hdr_options test
>    selftests/bpf: Test skops->skb_hwtstamp
> 
>   include/uapi/linux/bpf.h                      |  1 +
>   net/core/filter.c                             | 39 +++++++++++++++----
>   tools/include/uapi/linux/bpf.h                |  1 +
>   .../selftests/bpf/prog_tests/btf_dump.c       |  4 +-
>   .../bpf/prog_tests/tcp_hdr_options.c          |  6 ++-
>   .../bpf/progs/test_misc_tcp_hdr_options.c     |  4 ++
>   6 files changed, 43 insertions(+), 12 deletions(-)

LGTM for the whole series:
Acked-by: Yonghong Song <yhs@...com>