netdev - Re: [PATCH (repost) net-next] sched: add extack for tfilter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2uUsmVu6pKuHnBr@Laptop-X1>
Date:   Wed, 9 Nov 2022 19:53:22 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH (repost) net-next] sched: add extack for tfilter_notify

On Tue, Nov 08, 2022 at 10:55:44AM -0800, Jakub Kicinski wrote:
> My initial thought was to add an attribute type completely independent
> of the attribute space defined in enum nlmsgerr_attrs, add it in the
> TCA_* space. So for example add a TCA_NTF_WARN_MSG which will carry the
> string message.
> 
> We can also create a nest to carry the full nlmsgerr_attrs attributes
> with their existing types (TCA_NTF_EXT_ACK?). Each nest gets
> to choose what attribute set it carries.
> 
> That said, most of the ext_ack attributes refer to an input attribute by
> specifying the offset within the request. The notification recipient
> will not be able to resolve those in any meaningful way. So since only
> the string message will be of interest I reckon adding a full nest is
> an unnecessary complication?

Thanks for the explanation. I will try add the TCA_NTF_WARN_MSG to TCA
space.

Hangbin