netdev - [RFC] option to use proper skew timings for Micrel KSZ9021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Nov 2022 12:50:37 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     netdev@...r.kernel.org
Subject: [RFC] option to use proper skew timings for Micrel KSZ9021

Hi all,

Currently the skew timings in the PHY OF device node for KSZ9021 are 
specified in 200ps steps for historical reasons (due to an error in the 
original KSZ9021 datasheet), but the hardware actually uses 120ps steps. 
  (This is all explained in 
"Documentation/devicetree/bindings/net/micrel-ksz90x1.txt".)

I would like to add an optional boolean property to indicate that the 
skew timing properties are to be interpreted as "proper" skew timings 
(in 120ps steps) rather than fake skew timings.  When this property is 
true, the driver can divide the specified skew timing values by 120 
instead of 200.  The advantage of this is that the same skew timing 
property values can be used in the device node and will apply to both 
KSZ9021 and KSZ9031 as long as the values are in range for both chips. 
(The KSZ9021 supports a larger range that the KSZ9031 for 
"rxdX-skew-ps", "txdX-skew-ps", "rxdv-skew-ps" and "txen-skew-ps", but 
the KSZ9031 has a finer resolution of 60ps compared to the KSZ9021's 120ps.)

I'd like to know if this is a sensible suggestion, and if so, what would 
be a sensible name for the new property?

Best regards,
Ian Abbott

-- 
-=( Ian Abbott <abbotti@....co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-