netdev - Re: [PATCH net] net: cxgb3_main: disable napi when bind qsets failed in cxgb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y2upBRYd3hbxNV5n@unreal>
Date:   Wed, 9 Nov 2022 15:20:05 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, rajur@...lsio.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        jeffrey.t.kirsher@...el.com, weiyongjun1@...wei.com,
        yuehaibing@...wei.com
Subject: Re: [PATCH net] net: cxgb3_main: disable napi when bind qsets failed
 in cxgb_up()

On Mon, Nov 07, 2022 at 05:34:23PM +0800, Zhengchao Shao wrote:
> When failed to bind qsets in cxgb_up() for opening device, napi isn't
> disabled. When open cxgb3 device next time, it will reports a invalid
> opcode issue. Fix it. Only be compiled, not be tested.
> 
> Fixes: f7917c009c28 ("chelsio: Move the Chelsio drivers")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
>  drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>