netdev - Re: [PATCH net] net: mv643xx_eth: disable napi when init rxq or txq failed in mv643xx_eth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9106276-74b0-520f-51aa-ae38e2fd336e@huawei.com>
Date:   Wed, 9 Nov 2022 09:42:37 +0800
From:   shaozhengchao <shaozhengchao@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <sebastian.hesselbarth@...il.com>,
        <davem@...emloft.net>, <edumazet@...gle.com>, <pabeni@...hat.com>,
        <jeffrey.t.kirsher@...el.com>, <weiyongjun1@...wei.com>,
        <yuehaibing@...wei.com>
Subject: Re: [PATCH net] net: mv643xx_eth: disable napi when init rxq or txq
 failed in mv643xx_eth_open()



On 2022/11/9 9:27, Jakub Kicinski wrote:
> On Tue, 8 Nov 2022 10:51:56 +0800 Zhengchao Shao wrote:
>> When failed to init rxq or txq in mv643xx_eth_open() for opening device,
>> napi isn't disabled. When open mv643xx_eth device next time, it will
>> report a invalid opcode issue.
> 
> It will trigger a BUG_ON() in napi_enable()
> 
>> Fix it. Only be compiled, not be tested.
> 
> Please replace "Fix it. Only be compiled, not be tested."
> with "Compile tested only."
> 
>> Fixes: 527a626601de ("skge/sky2/mv643xx/pxa168: Move the Marvell Ethernet drivers")
> 
> This is not the commit which added this code, please find out where
> the code was added.

Hi Jakub:
	Thank you for your review. I will fix them in V2.

Zhengchao Shao