lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Nov 2022 17:58:57 +0100 From: Andrew Lunn <andrew@...n.ch> To: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@...ux.intel.com> Cc: "David S . Miller" <davem@...emloft.net>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@...el.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Voon Weifeng <weifeng.voon@...el.com>, Tan Tee Min <tee.min.tan@...el.com>, Looi Hong Aun <hong.aun.looi@...el.com>, Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@...el.com> Subject: Re: [PATCH net 1/1] net: stmmac: add check for supported link mode before mode change On Wed, Nov 09, 2022 at 10:43:29AM +0800, Noor Azura Ahmad Tarmizi wrote: > From: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@...el.com> > > Currently, change for unsupported speed and duplex are sent to the phy, > rendering the link to unknown speed (link state down). Something does not seem correct. See: https://elixir.bootlin.com/linux/v6.1-rc4/source/drivers/net/phy/phy.c#L816 /* We make sure that we don't pass unsupported values in to the PHY */ linkmode_and(advertising, advertising, phydev->supported); Do you somehow have phydev->supported set wrong? Andrew
Powered by blists - more mailing lists