netdev - Re: [PATCH net-next RFC 0/5] Update r8152 to version two

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9cdddf82-fb1a-45dd-57e9-b0f1c2728246@gmail.com>
Date:   Wed, 9 Nov 2022 15:43:21 +1100
From:   Albert Zhou <albert.zhou.50@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        nic_swsd@...ltek.com, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next RFC 0/5] Update r8152 to version two

On 9/11/22 07:50, Jakub Kicinski wrote:
> On Wed,  9 Nov 2022 02:33:37 +1100 Albert Zhou wrote:
>> This patch integrates the version-two r8152 drivers from Realtek into
>> the kernel. I am new to kernel development, so apologies if I make
>> newbie mistakes.
>>
>> I have tested the updated module in v6.1 on my machine, without any
>> issues.
> 
> What are you trying to achieve? Copy pasting 18k LoC into the kernel
> in a single patch is definitely not the way we do development. If there
> are features missing in the upstream driver, or you see discrepancies
> in the operation - please prepare targeted patches.

Hi Jakub,

The version-one r8152 module, for some reason, cannot maintain high
data-transfer speeds. I personally experienced this problem myself, when
I bought a new USB-C to ethernet adapter. The version-two module fixes
this issue.

I was searching for a way to include version two in the kernel, so that
future users would not have this issue. Being new to this process, I
na�vely contacted Greg, who advised me to send a patch through.

Unfortunately my attempts have not met your standard. I will try and
persist because I would like to improve the kernel in the best way.

Sincerely,

Albert Zhou

Download attachment "OpenPGP_0x218FE344C5A6867D.asc" of type "application/pgp-keys" (641 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (237 bytes)