netdev - Re: [EXT] [PATCH net 0/2] macsec: clear encryption keys in h/w drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54d3604c-a3da-24b5-af23-3cd5b8a9208a@marvell.com>
Date:   Wed, 9 Nov 2022 10:54:35 +0100
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Antoine Tenart <atenart@...nel.org>, <davem@...emloft.net>,
        <kuba@...nel.org>, <pabeni@...hat.com>, <edumazet@...gle.com>
CC:     <sd@...asysnail.net>, <netdev@...r.kernel.org>
Subject: Re: [EXT] [PATCH net 0/2] macsec: clear encryption keys in h/w
 drivers


> Commit aaab73f8fba4 ("macsec: clear encryption keys from the stack after
> setting up offload") made sure to clean encryption keys from the stack
> after setting up offloading but some h/w drivers did a copy of the key
> which need to be zeroed as well.
> 
> The MSCC PHY driver can actually be converted not to copy the encryption
> key at all, but such patch would be quite difficult to backport. I'll
> send a following up patch doing this in net-next once this series lands.
> 
> Tested on the MSCC PHY but not on the atlantic NIC.

Hi Antoine, reviewed both. Will try to test on atlantic when possible.

Reviewed-by: Igor Russkikh <irusskikh@...vell.com>

Thanks
  Igor