netdev - Re: [PATCH net v2] net: liquidio: release resources when liquidio driver open failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2zUwncZudQKI3t1@unreal>
Date:   Thu, 10 Nov 2022 12:38:58 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, dchickles@...vell.com, sburla@...vell.com,
        fmanlunas@...vell.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, richardcochran@...il.com,
        rvatsavayi@...iumnetworks.com, gregkh@...uxfoundation.org,
        tseewald@...il.com, weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net v2] net: liquidio: release resources when liquidio
 driver open failed

On Thu, Nov 10, 2022 at 06:30:37PM +0800, Zhengchao Shao wrote:
> When liquidio driver open failed, it doesn't release resources. Compile
> tested only.
> 
> Fixes: 5b07aee11227 ("liquidio: MSIX support for CN23XX")
> Fixes: dbc97bfd3918 ("net: liquidio: Add missing null pointer checks")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
> v2: simplify "if" judgment statements
> ---
>  .../net/ethernet/cavium/liquidio/lio_main.c   | 34 ++++++++++++++-----
>  1 file changed, 26 insertions(+), 8 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>