netdev - Re: [PATCH net v2 RESEND 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y2z3+QlfgpSFNbXm@lunn.ch>
Date:   Thu, 10 Nov 2022 14:09:13 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Tan Tee Min <tee.min.tan@...el.com>,
        Lay Kuan Loon <kuan.loon.lay@...el.com>,
        Ong Boon Leong <boon.leong.ong@...el.com>,
        Looi Hong Aun <hong.aun.looi@...el.com>,
        Voon Weifeng <weifeng.voon@...el.com>,
        Zulkifli Muhammad Husaini <muhammad.husaini.zulkifli@...el.com>,
        Gan Yi Fang <yi.fang.gan@...el.com>
Subject: Re: [PATCH net v2 RESEND 1/1] net: phy: dp83867: Fix SGMII FIFO
 depth for non OF devices

On Thu, Nov 10, 2022 at 01:49:38PM +0800, Michael Sit Wei Hong wrote:
> Current driver code will read device tree node information,
> and set default values if there is no info provided.
> 
> This is not done in non-OF devices leading to SGMII fifo depths being
> set to the smallest size.
> 
> This patch sets the value to the default value of the PHY as stated in the
> PHY datasheet.
> 
> Fixes: 4dc08dcc9f6f ("net: phy: dp83867: introduce critical chip default init for non-of platform")
> Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@...el.com>

https://www.spinics.net/lists/netdev/msg858366.html

When sending a new version, please add any Acked-by, or Reviewed-by
tags you have received. It helps get your patch merged if it can
easily be seen is has been reviewed.

   Andrew