netdev - Re: [PATCH net-next v10 10/10] ice: add documentation for devlink-rate implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d739c8b0-e43d-4b7a-f312-2edace91c953@intel.com>
Date:   Thu, 10 Nov 2022 18:40:00 +0100
From:   "Wilczynski, Michal" <michal.wilczynski@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, <alexandr.lobakin@...el.com>,
        <jacob.e.keller@...el.com>, <jesse.brandeburg@...el.com>,
        <przemyslaw.kitszel@...el.com>, <anthony.l.nguyen@...el.com>,
        <ecree.xilinx@...il.com>, <jiri@...nulli.us>
Subject: Re: [PATCH net-next v10 10/10] ice: add documentation for
 devlink-rate implementation



On 11/10/2022 6:03 PM, Jakub Kicinski wrote:
> On Thu, 10 Nov 2022 17:54:03 +0100 Wilczynski, Michal wrote:
>>> Nice, but in case DCB or TC/ADQ gets enabled devlink rate will just
>>> show a stale hierarchy?
>> Yes there will be hierarchy exported during the VF creation, so if
>> the user enable DCB/ADQ in the meantime, it will be a stale hierarchy.
>> User won't be able to modify any nodes/parameters.
> Why not tear it down if it's stale?

I don't think there is any harm in tearing it down in those cases,
can add a commit that tears down the hierarchy when DCB/ADQ gets
activated.