netdev - Re: [PATCH net-next v2] ethtool: add netlink based get rxfh support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eba940d8-a2da-9a7e-2802-fbac680b7df6@intel.com>
Date:   Thu, 10 Nov 2022 16:08:04 -0600
From:   "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "corbet@....net" <corbet@....net>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: Re: [PATCH net-next v2] ethtool: add netlink based get rxfh support

On 11/9/2022 6:46 PM, Jakub Kicinski wrote:
> On Thu, 10 Nov 2022 00:26:23 +0000 Mogilappagari, Sudheer wrote:
>>> Can we describe in more detail which commands are reimplemented?
>>> Otherwise calling the command RXFH makes little sense.
>>> We may be better of using RSS in the name in the first place.
>> This is the ethtool command being reimplemented.
>> ethtool -x|--show-rxfh-indir DEVNAME   Show Rx flow hash indirection table and/or RSS hash key
>>          [ context %d ]
>>
>> Picked RXFH based on existing function names and ethtool_rxfh
>> structure. If it needs to change, how about RSS_CTX or just RSS ?
> I vote for just RSS.

Can we use QGRP as a prefix to indicate that these are per-queue group parameters
and not restricted to RSS related parameters?

   QGRP_CONTEXT
   QGRP_RSS_HFUNC
   QGRP_RSS_KEY
   QGRP_RSS_INDIR_TABLE

In future, we would like to add per-queue group parameters like
   QGRP_INLINE_FLOW_STEERING (Round robin flow steering of TCP flows)

Thanks
Sridhar